git-scm.com icon indicating copy to clipboard operation
git-scm.com copied to clipboard

Published 20 hours ago • verified publisher icon git

Enhancement - Video pages do not link to one another - continuous watch requires multiple clicks

Open yotamcons opened this issue 2 years ago • 4 comments

URL of pages that could use the change

  1. https://git-scm.com/video/what-is-version-control2.
  2. https://git-scm.com/video/what-is-git3.
  3. https://git-scm.com/video/get-going

Problem

Going over the four videos in the page, after I finished watching each I needed to get back to the videos home page, and then click into the next video. This can be made easier by simply adding a link to the next video page.

When a video finishes playing the Vimeo player does pop suggestions (See attached image) - but the following videos don't necessarily appear there, and aren't named or ordered

Screen Shot 2022-07-27 at 17 07 32

yotamcons avatar Jul 27 '22 14:07 yotamcons

thanks for the suggestion @yotamcons ! you are totally right, it could be way more user friendly.

i don't think at this moment there's the concept of order in the videos, but maybe we can just hardcode the link to other video since this list is not updated for a long time.

would you be interested in contributing with a MR @yotamcons ?

pedrorijo91 avatar Jul 31 '22 10:07 pedrorijo91

Hi Pedro, Could you contact me privately to understand what it would require? I'm not familiar with Ruby or web development (other than basic HTML)

yotamcons avatar Jul 31 '22 12:07 yotamcons

hey @yotamcons ! sorry for taking some time.

so the page where the video listing is rendered is https://github.com/git/git-scm.com/blob/main/app/views/doc/videos.html.erb, and the page that renders each video is https://github.com/git/git-scm.com/blob/main/app/views/doc/watch.html.erb

looking at the way we link each video on the listing it seems we could hardcode something in the watch.html.erb view as well:

https://github.com/git/git-scm.com/blob/main/app/views/doc/videos.html.erb#L13-L19

my suggestion would be to start by setting up the project locally (see https://github.com/git/git-scm.com#setup), and then try to play with those 2 views to create some early version. feel free to ping if you need more guidance!

pedrorijo91 avatar Aug 07 '22 14:08 pedrorijo91

@pedrorijo91 Unfortunately this seems like to much learning I'll need to do for that, sorry i wouldn't be able to help

yotamcons avatar Aug 31 '22 16:08 yotamcons