git-reference
git-reference copied to clipboard
git
fr version
@humboldtux i know this is almost 2 years old at this point. Do you have interest in finishing it?
also cc @helaili for helping with double checking french words. We should also look at making some of this as close to git-scm.com as possible.
Oops, forgot to say thanks to @humboldtux for responding and getting back at this!
I'm taking Pro Git french translation guidelines as a reference for translation. Do you know if there is any official french translation for git-scm.com?
@humboldtux i know there is a French version of the book at https://git-scm.com/book/fr. Does that help?
Let me know if you could do a quick overview of some of this material.
Also cc @tdd, if you could give this a quick overview that would be :sparkles: amazing :sparkles:
Woah, hadn't seen this at all, oddly. Sorry I couldn't pitch in.
I can find time next week to address this, if that works for you still.
On vacation for two more days. Set a calendar reminder to review this and double check everything when I come back!
coming back around to this now. sorry for the delay @humboldtux.
@tdd did you get a chance to look at this yet? I know it's early in the week still though. If you are going to be busier than you anticipated, I can bring in some other FR speaking people as well!
Hey Brent,
I expect to work on this today. Will post a follow-up here.
On Tue, Feb 23, 2016, at 09:24, Brent Beer wrote:
coming back around to this now. sorry for the delay @humboldtux[1].
@tdd[2] did you get a chance to look at this yet? I know it's early in the week still though. If you are going to be busier than you anticipated, I can bring in some other FR speaking people as well!
— Reply to this email directly or view it on GitHub[3].
Christophe Porteneuve [email protected]
Links:
- https://github.com/humboldtux
- https://github.com/tdd
- https://github.com/git/git-reference/pull/79#issuecomment-187599298
@humboldtux d'une manière générale, je remarque que le contenu est presque 100% identique à l'A3 de Pro Git v2, lequel a déjà une trad FR. Et le texte FR proposé ici en diverge régulièrement (ne serait-ce que les titres de section) — c'est intentionnel ? Ou juste, tu n'avais pas remarqué ?
À mon sens, pour la cohérence, le mieux serait de reprendre / affiner la trad présente dans l'A3 de Pro Git, non ?
Au temps pour moi, malgré une structure quasi identique (et côté titres, ce serait bien d'homogénéiser), le contenu est distinct (celui de Pro Git a une tonne de liens vers le reste du livre).
Hey all,
OK so this is a lot of work, and I have to also make headway on numerous other tasks here. So I'll pepper this review throughout my next 4 days (although I'm consulting tmw so don't expect anything then).
I'll try and do diff and commit today, perhaps also reset. Then rm, stash, the initial chapter on getting/creating and the final inspect/compare chapter on Thursday; and the remainder on Friday. We'll see how this goes.
@tdd thank you so much for the incredibly detailed review and @humboldtux for getting this started! Love it
Unexpected workload hitting us here, I'll have to keep the review on-and-off for the next few days. Expect rm, stash and the Getting/Creating page tomorrow, but the rest will have to wait until next week, I'm afraid.
@humboldtux it'd be great if you could start pushing updates based on the feedback, so the relevant line notes start collapsing away in the file and conversation views :wink:
@tdd i will start pushing ASAP ... and correct accents and nonbreakable space in other files before you review them :smile:
Hey @humboldtux,
Thanks for getting started on actioning the review. That's great. There are a couple things I'd like to say, though.
First, let me state that I appreciate all efforts from people to lower the barrier to entry to the (notoriously English-averse) French audience. I do a fair share of translation myself, and despite using the English original docs exclusively I'm always grateful to community members that give their time and energy to translation efforts. Your work also contains remarkably few grammar/spelling/syntax issues, which is great.
Also, I'm a demanding reviewer, and due to GitHub's line-comments UI, it can sometimes feel like more of a rewrite than a review. You take it all in good stride, which is wonderful. So again, thanks a ton for doing all this. :clap:
That being said, I take issue :unamused: with your latest PR, #107. Allow me to explain why, as a sort of quick memo on FLOSS politics / workflows / social coding.
Whenever I get to work on translating English material to French, I first focus on the French edition. When I find that the original text has flaws IMHO, I shelve that for later feedback to the original authors, and usually dare to alter the French text to correct and improve this. That's what friends and I are doing on a number of NodeSchool workshops, for instance.
When I do get around to providing feedback on the original text, I follow the usual PR quality guidelines, though:
- :x: Avoid abrasive / harsh language :triumph:
- :white_check_mark: Provide detailed rationale in the pull request summary (usually through the original commits)
- :white_check_mark: Provide replacement content for improvement, when applicable.
Your PR doesn't do that, it just says "that's bad, let's strip it", without rationale (why is that bad? what is "bad"?) nor solution (what should be said instead?). This is unfortunate in itself, and can feel agressive :facepunch: to the content's original authors (which are many, in this instance). Remember the classic rule: when in writing, everything sounds harsher than orally / face-to-face.
But what I dislike most is that this PR offsets :point_right: its responsibility to me: it starts with "According to @tdd…", and without even checking with me first! That's a pretty sloppy social move, to put things mildly.
Yes, I have issues with a few pieces of the English text, that are in my view either simply inaccurate (which can be forgiven if Git Ref clearly states it aims for conciseness) or factually incorrect / misleading (which is a bigger issue).
Yes, we should address that at some point, perhaps after wrapping up the French version.
No, this shouldn't be done that way. If you're going to put a PR out there for every piece at stake, that's great and I salute you for your commitment, but…
- Make sure you understand what the issue is
- Put the PR out under your own name and attribution: take responsibility for it
- Take the time to detail in the commit's post-first-line content and PR summary text what the issue is, what improvement you're proposing, etc.
Perhaps @brntbeer has useful things to say on this and the general process for fluid collaboration around potentially controversial text issues?
Anyway, please do not get this as a mad slap on the wrist. You may very well have done this just in a rush, and not paused to consider the flow or social issues of it. And that's okay, just be a bit more careful next time.
Thanks again for all your work on the French version. I look forward to reviewing the rest.
Best,
Christophe
I'm really sorry @tdd, i truly realizes not only my PR was bad and that i too made a bad move by naming you in it this way. This was a stupid mistake from me done in a hurry: please excuse my enthusiasm which lead me to this lack of rigor and ethics.
I hope you will accept my apologies @tdd for calling you int his PR, and @brntbeer for not following basic contribution guidelines.
Chill, Benoît, no need for grovelling! This is a place for humans, and humans get carried away! :wink:
I shelve that for later feedback to the original authors, and usually dare to alter the French text to correct and improve this. That's what friends and I are doing on a number of NodeSchool workshops, for instance.
@tdd i think that's a great approach. Keeps a single source of truth for the translations.
Perhaps @brntbeer has useful things to say on this and the general process for fluid collaboration around potentially controversial text issues?
This is true. I think when in doubt when opening a PR: explain where you're coming from, be overly friendly, and be excited. I sometimes don't do this, and it's good to see examples and be reminded from other members of the community always =)
I hope you will accept my apologies @tdd for calling you int his PR, and @brntbeer for not following basic contribution guidelines.
@humboldtux not a problem at all! I think the amount of time and effort you and @tdd are putting in in general is mind blowing and so inspiring and exciting to me, personally.