git-tfs icon indicating copy to clipboard operation
git-tfs copied to clipboard

Support TLS 1.2

Open nullstatement opened this issue 7 years ago • 1 comments

Support when tfs is only using TLS 1.2

Not sure the best way to fix this generally but I fixed it in the code by adding the line ServicePointManager.SecurityProtocol = SecurityProtocolType.Tls12; as the first line in Program.cs

Error:

Technical information (for administrator): The request was aborted: Could not create SSL/TLS secure channel. The request was aborted: Could not create SSL/TLS secure channel.

nullstatement avatar Nov 14 '18 02:11 nullstatement

I think that if we could add a parameter to configure the tls version (here: https://github.com/git-tfs/git-tfs/blob/master/src/GitTfs/Commands/Fetch.cs#L74) to set the value if specified and store it in the repository settings (like that https://github.com/git-tfs/git-tfs/blob/master/src/GitTfs/Commands/Fetch.cs#L138), it will solve the problem.

And if we could catch the exception and display a friendly message that inform the user of the parameter, it would be perfect..

Do you think you could do a PR?

pmiossec avatar Nov 14 '18 09:11 pmiossec