git-commit-id-maven-plugin icon indicating copy to clipboard operation
git-commit-id-maven-plugin copied to clipboard

expose properties for executing this plugin from command line without specify plugin configuration in pom.xml

Open cloorc opened this issue 3 years ago • 3 comments

Context

We need to execute this plugin with goal revision without specify this plugin in an existing maven project. We can do this by specifying parameters from command line. And this commit is going to expose these parameters to command line is enough.

Contributor Checklist

  • 🆗 Added relevant integration or unit tests to verify the changes
  • 🆗 Update the Readme or any other documentation (including relevant Javadoc)
  • 🆗 Ensured that tests pass locally: mvn clean package
  • 🆗 Ensured that the code meets the current checkstyle coding style definition: mvn clean verify -Pcheckstyle -Dmaven.test.skip=true -B

cloorc avatar Sep 02 '22 06:09 cloorc

Hello, thanks for your contribution! I remember that we had issues with those properties / settings and maven. Effectively the command-line didn't overwrite anything that was encoded in the pom.xml.

For further details see https://github.com/git-commit-id/git-commit-id-maven-plugin/issues/315#issuecomment-326148731 I'd need to test if this somehow suffers similar problems. I'm honestly a bit sceptical...

TheSnoozer avatar Sep 06 '22 19:09 TheSnoozer

Hello, thanks for your contribution! I remember that we had issues with those properties / settings and maven. Effectively the command-line didn't overwrite anything that was encoded in the pom.xml.

For further details see #315 (comment) I'd need to test if this somehow suffers similar problems. I'm honestly a bit sceptical...

Yes, it seems like a but of Apache Maven itself. The hard-coded skip won't be overrided by command line options. But properties will. Such as :

<properties>
  <xxx.skip>false</xxx.skip>
</properties>
......
<skip>${xxx.skip}</skip>

cloorc avatar Sep 07 '22 02:09 cloorc

Hello, thanks for your contribution! I remember that we had issues with those properties / settings and maven. Effectively the command-line didn't overwrite anything that was encoded in the pom.xml.

For further details see https://github.com/git-commit-id/git-commit-id-maven-plugin/issues/315#issuecomment-326148731 I'd need to test if this somehow suffers similar problems. I'm honestly a bit sceptical...

Hi, could we just leave the maven defection to maven itself? And this feature could be useful without predefined configuration anyway!

cloorc avatar Sep 20 '22 04:09 cloorc