Girish KS

Results 10 comments of Girish KS

Details Fixed Issues $ n/a Tests Run the web app and verify that data-testID is set correctly. ![image](https://github.com/Expensify/App/assets/33298211/e2a0401c-515a-4c53-9cce-0e43d5099f9e) ![image](https://github.com/Expensify/App/assets/33298211/233de58b-4852-4cba-a85e-db5bb5011baa)

I have read the CLA Document and I hereby sign the CLA

@hayata-suenaga I do not have access to that slack space.

@hayata-suenaga I have added testids as per rory's suggestion. I am not sure why tests are failing as i have only added test id's there should be no changes to...

> did you add IDs to root components/elements? Yes i added to the root components which are implementing native react components

@roryabraham Yeah i realized this after submitting PR, i am making changes actively but its taking time as it has to change in multiple places.

Sure @roryabraham, for now i am reverting the testID from DisplayNames because its cascading a lot of changes in the other components. Will submit new commit soon.

@roryabraham I have narrowed down to just one change. I have also verified that are no errors: ![image](https://github.com/Expensify/App/assets/33298211/f0c94055-c85c-4cfb-99cd-e22e08cbd49f) and its signed: ![Pasted Graphic 1](https://github.com/Expensify/App/assets/33298211/6ebf9d61-6187-49ee-8a57-025a7e85f9a8)

I checked all the items on the checklist, looks like checklist is passing now.

i rebased and force pushed commits as per @roryabraham suggestion.