phpunit-selenium icon indicating copy to clipboard operation
phpunit-selenium copied to clipboard

Published 20 hours ago • verified publisher icon giorgiosironi

Add phpcs + fix code

Open pajon opened this issue 5 years ago • 3 comments

Hi guys,

i added phpcs to improve code quality. Rules were created from Doctrine + some rules were disabled.

Feel free to discus about it.

Thank you

P.S. This PR contains #445 fix.

pajon avatar Mar 19 '20 16:03 pajon

@thewunder Sorry for tagging, but i need finish and merge this PR. I want continue with next changes.

pajon avatar Mar 19 '20 16:03 pajon

I also added type hints to code. Sorry for doing multiple changes in one MR, but I understand you don't have much time to merge multiple MR. If you want i can split these changes into multiple MR.

pajon avatar Mar 21 '20 11:03 pajon

@thewunder Can you review the PR?

Thank you

pajon avatar Jun 15 '20 14:06 pajon