Gino Miceli

Results 413 comments of Gino Miceli

> Agreed to show an error message on the UI and exit, and log in debug. [@jo-spek](https://github.com/jo-spek) can check the translations @kenstershiro Unfortunately, Play services doesn't always report success or...

@anandwana001 The easy way to solve this would be to split the init method in `StartupViewModel` into two, and to show one progress dialog while initializing Play services, dismiss once...

> Not sure the different message adds much value to the user, but if it's a simple change I'd agree. In some cases, the OS never lets the app know...

The following fix in #2920 doesn't work as intended: https://github.com/google/ground-android/blob/9ef90adb6cc8aade4bd87350fe820fd8c0a23ace/ground/src/main/java/com/google/android/ground/ui/startup/StartupFragment.kt#L50-L60 `viewModel.initializeLogin()` will not loop until Play services is installed since `StartupFragment` and its scope are stopped when the app navigates...

> > Currently, we show the "Initializing..." spinner while that's happened. Perhaps we should add a distinct message for this case, e.g. "Waiting for Play services...". Wdyt? > > Not...

I'll keep this for now since it's a safe fallback in case my previous comment was wrong. Closing.

The problem is actually in the config - the terms of service don't contain Markdown, but `#NEWLINE#` for new lines. @rfontanarosa Doesn't the web interface already support Markdown for ToS?...

Hi @anandwana001 What is the status of this PR? Has it been abandoned?

@anandwana001 I see this is allocated for the next Iteration which starts tomorrow, leaving this open for now.