I am incorporating the balanced and compressed COO format in Ginkgo ( https://doi.org/10.1002/cpe.6515 , https://doi.org/10.1007/978-3-030-71593-9_7).

I would like to know if the bccoo format is properly implemented. Note that, only core, reference and omp executors are considered.

The OMP and CUDA versions is slightly different, and, therefore, I would like to verify the former before developing the latter.

Thanks in advance!!

Nov 30 '21 21:11 josealiaga

Thanks for the PR. Could you provide a bit of high level overview on what you are working on?

Dec 01 '21 10:12 greole

Hi,

I am incorporating the balanced and compressed COO format in GinkGo ( https://doi.org/10.1002/cpe.6515 , https://doi.org/10.1007/978-3-030-71593-9_7).

The OMP and CUDA versions is slightly different, and, therefore, I would like to verify the former before developing the latter.

Thanks in advance!!

Best regards,

José I. Aliaga

El mié, 1 dic 2021 a las 11:29, greole @.***>) escribió:

Thanks for the PR. Could you provide a bit of high level overview on what you are working on?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ginkgo-project/ginkgo/pull/935#issuecomment-983502096, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFCY66NZQVUMNLETF6LPOBLUOX2JFANCNFSM5JC4HY3A . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Dec 01 '21 13:12 josealiaga

format-rebase!

Dec 02 '21 15:12 thoasm

Error: Rebase failed, see the related Action for details

Dec 02 '21 15:12 ginkgo-bot

Basically, all comments have been included. Probably, the names in core/matrix/bccoo_helper.hpp should be adapted to the snake_case. Do you agree?

Jan 11 '22 20:01 josealiaga

Codecov Report

Merging #935 (8e09317) into develop (621f991) will increase coverage by 3.02%. The diff coverage is 93.21%.

:exclamation: Current head 8e09317 differs from pull request most recent head 2573bf0. Consider uploading reports for the commit 2573bf0 to get more accurate results

@@             Coverage Diff             @@
##           develop     #935      +/-   ##
===========================================
+ Coverage    90.50%   93.53%   +3.02%     
===========================================
  Files          505      483      -22     
  Lines        43856    40368    -3488     
===========================================
- Hits         39693    37758    -1935     
+ Misses        4163     2610    -1553

Impacted Files	Coverage Δ
core/device_hooks/common_kernels.inc.cpp	`0.00% <0.00%> (ø)`
include/ginkgo/core/matrix/coo.hpp	`91.48% <ø> (ø)`
include/ginkgo/core/matrix/csr.hpp	`45.36% <ø> (+1.81%)`	:arrow_up:
include/ginkgo/core/matrix/dense.hpp	`95.58% <ø> (+0.35%)`	:arrow_up:
omp/matrix/csr_kernels.cpp	`93.43% <0.00%> (+7.22%)`	:arrow_up:
omp/matrix/dense_kernels.cpp	`94.16% <0.00%> (+15.15%)`	:arrow_up:
omp/matrix/coo_kernels.cpp	`86.15% <20.00%> (-2.74%)`	:arrow_down:
include/ginkgo/core/matrix/bccoo.hpp	`73.46% <73.46%> (ø)`
core/matrix/bccoo_helper.hpp	`85.03% <85.03%> (ø)`
omp/matrix/bccoo_kernels.cpp	`85.48% <85.48%> (ø)`
... and 263 more