ginkgo icon indicating copy to clipboard operation
ginkgo copied to clipboard

Add support for Batch Operators

Open pratikvn opened this issue 3 years ago • 2 comments

This PR is the first in a sequence of PR's to integrate the Batch functionality in batch-develop into main develop. This PR adds a batch versions and specializations for the dim, stride and the LinOp hierarchy.

TODO

  • [x] Complete the documentation for the different batch classes.
  • [ ] Try to see if duplication between the LinOp and the BatchLinOp hierarchy can be reduced.

pratikvn avatar Oct 25 '21 15:10 pratikvn

Codecov Report

Base: 91.50% // Head: 94.68% // Increases project coverage by +3.18% :tada:

Coverage data is based on head (2f4832e) compared to base (99c8d73). Patch coverage: 88.06% of modified lines in pull request are covered.

:exclamation: Current head 2f4832e differs from pull request most recent head cbe44c3. Consider uploading reports for the commit cbe44c3 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #912      +/-   ##
===========================================
+ Coverage    91.50%   94.68%   +3.18%     
===========================================
  Files          556      438     -118     
  Lines        47456    35948   -11508     
===========================================
- Hits         43425    34038    -9387     
+ Misses        4031     1910    -2121     
Impacted Files Coverage Δ
include/ginkgo/core/log/logger.hpp 74.50% <25.00%> (-21.33%) :arrow_down:
include/ginkgo/core/base/exception_helpers.hpp 65.90% <57.57%> (-25.00%) :arrow_down:
core/test/base/batch_lin_op.cpp 93.06% <93.06%> (ø)
include/ginkgo/core/base/batch_lin_op.hpp 97.05% <97.05%> (ø)
include/ginkgo/core/base/batch_dim.hpp 97.61% <97.61%> (ø)
core/test/base/batch_dim.cpp 100.00% <100.00%> (ø)
test/utils/executor.hpp 14.28% <0.00%> (-85.72%) :arrow_down:
omp/matrix/fbcsr_kernels.cpp 0.00% <0.00%> (-57.54%) :arrow_down:
include/ginkgo/core/base/machine_topology.hpp 83.33% <0.00%> (-16.67%) :arrow_down:
omp/solver/cb_gmres_kernels.cpp 78.48% <0.00%> (-15.19%) :arrow_down:
... and 459 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Oct 26 '21 03:10 codecov[bot]

Error: The following files need to be formatted:

core/test/base/batch_dim.cpp
core/test/base/batch_lin_op.cpp
include/ginkgo/core/base/batch_dim.hpp
include/ginkgo/core/base/batch_lin_op.hpp

You can find a formatting patch under Artifacts here or run format! if you have write access to Ginkgo

ginkgo-bot avatar Dec 21 '22 12:12 ginkgo-bot

Note: This PR changes the Ginkgo ABI:

Functions changes summary: 92 Removed, 298 Changed (57052 filtered out), 98 Added functions
Variables changes summary: 0 Removed, 0 Changed, 0 Added variable

For details check the full ABI diff under Artifacts here

ginkgo-bot avatar Dec 21 '22 13:12 ginkgo-bot

Stale PR. Will be superseded by an updated PR.

pratikvn avatar Feb 03 '23 14:02 pratikvn