ginkgo icon indicating copy to clipboard operation
ginkgo copied to clipboard

split the library into small pieces if need

Open yhmtsai opened this issue 6 months ago • 2 comments

In #1734, when user compile ginkgo into several architectures, there will be too many symbols/references in one library. Thus, we need to split it to different library and link later. If someone knows nvcc specific flag to solve this issue, please let me know. The default behavior stay the same as the previous one unless if user set GINKGO_SPLIT_LIBRARY_NUM > 1. AFAIR, @nbeams mentioned that the number of libraries now in Ginkgo already gives some pain for project. It is another reason to keep the original behavior if they do not encounter the issue.

TODO:

  • [ ] if the approach is acceptable, apply it to the other parts.

yhmtsai avatar May 30 '25 12:05 yhmtsai

Error: The following files need to be formatted:

dpcpp/preconditioner/isai_kernels.dp.cpp
dpcpp/preconditioner/jacobi_generate_instantiate.inc.dp.cpp

You can find a formatting patch under Artifacts here or run format! if you have write access to Ginkgo

ginkgo-bot avatar May 31 '25 01:05 ginkgo-bot

we might only support this after cuda 12.4 because the thrust issue between different shared library inspired by #1929

yhmtsai avatar Sep 09 '25 16:09 yhmtsai