ginkgo
ginkgo copied to clipboard
Default HIP_PATH does not work with ROCm >= 6.0
Bumping issue from https://github.com/ginkgo-project/ginkgo/issues/1529#issuecomment-2053598746:
hip_path.cmake
still defaults to /opt/rocm/hip
for HIP_PATH
which does not work with ROCm 6.0:
https://github.com/ginkgo-project/ginkgo/blob/a8a407f35887c480af66500c20dc53a41d2f7604/cmake/hip_path.cmake#L3
Furthermore, hip.cmake
has a code path where $ENV{HIP_PATH}/..
is used for `ROCM_PATH:
https://github.com/ginkgo-project/ginkgo/blob/a8a407f35887c480af66500c20dc53a41d2f7604/cmake/hip.cmake#L20
It would be nice if Ginkgo could auto-detect ROCm version and use the correct paths for 6.0 by default :wink: