ginkgo
ginkgo copied to clipboard
Some fixes for compiling with the `-D_GLIBCXX_DEBUG` flag.
This PR adds some recommended fixes needed to compile by adding the -D_GLIBCXX_DEBUG
flag to all the source files. More details about the flag and its purpose can be found here
Some issues:
- It seems like this significantly increases the runtime of some of the tests (due to the explicit bound checks ?).
- When using stdlib containers in device code, workarounds are needed, for example in accessors.
Not sure if we want to have this for 1.5.0.
Fixes #1143
LGTM too. Feel free to approve and merge when you are ready.
We had three small bugs that need to be fixed, and I'll try to reduce the test runtime, but otherwise it's ready, yes