ginkgo icon indicating copy to clipboard operation
ginkgo copied to clipboard

Some fixes for compiling with the `-D_GLIBCXX_DEBUG` flag.

Open pratikvn opened this issue 2 years ago • 1 comments

This PR adds some recommended fixes needed to compile by adding the -D_GLIBCXX_DEBUG flag to all the source files. More details about the flag and its purpose can be found here

Some issues:

  1. It seems like this significantly increases the runtime of some of the tests (due to the explicit bound checks ?).
  2. When using stdlib containers in device code, workarounds are needed, for example in accessors.

Not sure if we want to have this for 1.5.0.

Fixes #1143

pratikvn avatar Nov 03 '22 14:11 pratikvn

LGTM too. Feel free to approve and merge when you are ready.

pratikvn avatar Apr 04 '24 10:04 pratikvn

We had three small bugs that need to be fixed, and I'll try to reduce the test runtime, but otherwise it's ready, yes

upsj avatar Apr 04 '24 10:04 upsj