ginkgo
ginkgo copied to clipboard
Add algorithm choice for triangular solvers
This PR adds a parameter to the triangular solvers for choosing the algorithm to be used rather than making this depend on the matrix spmv strategy. Currently it is only relevant for CUDA, as for the other executors there is only one algorithm available.
Currently, you are dependent on both the strategy of the matrix (for the solve) and the algorithm enum (for the generate).
Is there a reason why you did not make both the solving and the generation dependent on the algorithm enum solver::trisolve_algorithm
?
Currently, you are dependent on both the strategy of the matrix (for the solve) and the algorithm enum (for the generate). Is there a reason why you did not make both the solving and the generation dependent on the algorithm enum
solver::trisolve_algorithm
?
Good catch, thanks! I completely overlooked the solve part.. will update this in a minute
rebase!
Error: The following files need to be formatted:
include/ginkgo/ginkgo.hpp
You can find a formatting patch under Artifacts here or run format!
if you have write access to Ginkgo
Note: This PR changes the Ginkgo ABI:
Functions changes summary: 0 Removed, 64 Changed (1424 filtered out), 87 Added functions
Variables changes summary: 0 Removed, 0 Changed, 0 Added variable
For details check the full ABI diff under Artifacts here