ginkgo icon indicating copy to clipboard operation
ginkgo copied to clipboard

Add algorithm choice for triangular solvers

Open fritzgoebel opened this issue 2 years ago • 5 comments

This PR adds a parameter to the triangular solvers for choosing the algorithm to be used rather than making this depend on the matrix spmv strategy. Currently it is only relevant for CUDA, as for the other executors there is only one algorithm available.

fritzgoebel avatar Jul 27 '22 11:07 fritzgoebel

Currently, you are dependent on both the strategy of the matrix (for the solve) and the algorithm enum (for the generate). Is there a reason why you did not make both the solving and the generation dependent on the algorithm enum solver::trisolve_algorithm?

thoasm avatar Jul 27 '22 13:07 thoasm

Currently, you are dependent on both the strategy of the matrix (for the solve) and the algorithm enum (for the generate). Is there a reason why you did not make both the solving and the generation dependent on the algorithm enum solver::trisolve_algorithm?

Good catch, thanks! I completely overlooked the solve part.. will update this in a minute

fritzgoebel avatar Jul 27 '22 13:07 fritzgoebel

rebase!

upsj avatar Aug 23 '22 14:08 upsj

Error: The following files need to be formatted:

include/ginkgo/ginkgo.hpp

You can find a formatting patch under Artifacts here or run format! if you have write access to Ginkgo

ginkgo-bot avatar Aug 23 '22 14:08 ginkgo-bot

Note: This PR changes the Ginkgo ABI:

Functions changes summary: 0 Removed, 64 Changed (1424 filtered out), 87 Added functions
Variables changes summary: 0 Removed, 0 Changed, 0 Added variable

For details check the full ABI diff under Artifacts here

ginkgo-bot avatar Aug 23 '22 14:08 ginkgo-bot