ginkgo icon indicating copy to clipboard operation
ginkgo copied to clipboard

Add sparse direct interface

Open upsj opened this issue 2 years ago • 2 comments

upsj avatar Jul 18 '22 12:07 upsj

Error: The following files need to be formatted:

include/ginkgo/ginkgo.hpp

You can find a formatting patch under Artifacts here or run format! if you have write access to Ginkgo

ginkgo-bot avatar Sep 09 '22 16:09 ginkgo-bot

Note: This PR changes the Ginkgo ABI:

Functions changes summary: 500 Removed, 64 Changed (1424 filtered out), 3988 Added functions
Variables changes summary: 0 Removed, 0 Changed, 0 Added variable

For details check the full ABI diff under Artifacts here

ginkgo-bot avatar Sep 09 '22 17:09 ginkgo-bot

@MarcelKoch the only macros I could actually use would be GKO_FACTORY_PARAM_*, the others make assumptions that are not valid here. Would that be sufficient until we resolve #1162 ?

upsj avatar Nov 03 '22 11:11 upsj

@upsj sorry for being vague there, yes that is exactly what I meant.

MarcelKoch avatar Nov 03 '22 11:11 MarcelKoch

This seems to be hitting the 0:45 job timeout on HoreKa now. Maybe we should increase to 1h. https://gitlab.com/ginkgo-project/ginkgo-public-ci/-/jobs/3269009595.

tcojean avatar Nov 03 '22 15:11 tcojean

Note: This PR changes the Ginkgo ABI:

Functions changes summary: 0 Removed, 0 Changed, 3350 Added functions
Variables changes summary: 0 Removed, 0 Changed, 0 Added variable

For details check the full ABI diff under Artifacts here

ginkgo-bot avatar Nov 04 '22 10:11 ginkgo-bot

rebase!

upsj avatar Nov 04 '22 19:11 upsj

Error: PR already merged!

ginkgo-bot avatar Nov 04 '22 19:11 ginkgo-bot