ginkgo
ginkgo copied to clipboard
preconditioner Ic without the solver type
This PR makes the preconditioner IC wrapper without SolverType. It moves the solver type into the factory operator.
When we provide the solver, the SolverType is useless but we still need to put it into template.
the type requirement is the same as original.
Ic<SolverType>::build().on(exec);
-> IcWrapper::build().with_l_solver_factory(IcWrapper<SolverType>(exec)).on(exec)
or any IcWrapper::build().with_l_solver_factory(linop_factory).on(exec);
It's also good for ResourceManager.
TODO:
- [ ] change the explicit type as when merging SolverBase
- [ ] add IluWrapper
Error: The following files need to be formatted:
test/test_install/test_install.cpp
You can find a formatting patch under Artifacts here or run format!
if you have write access to Ginkgo
Note: This PR changes the Ginkgo ABI:
Functions changes summary: 0 Removed, 8 Changed (916 filtered out), 0 Added functions
Variables changes summary: 0 Removed, 0 Changed, 0 Added variable
For details check the full ABI diff under Artifacts here
The whole factorization preconditioner setup needs to be reworked (https://github.com/ginkgo-project/ginkgo/issues/472), do you need this urgently? I am not really happy with adding a second *Wrapper type that does the same thing and likely removing it with 2.0 again.