ginkgo icon indicating copy to clipboard operation
ginkgo copied to clipboard

Published 20 hours ago • verified publisher icon ginkgo-project

GCR Krylov Solver

Open kyrillh opened this issue 2 years ago • 5 comments

kyrillh avatar Apr 14 '22 07:04 kyrillh

label!

upsj avatar Apr 14 '22 07:04 upsj

check-format!

upsj avatar Apr 14 '22 07:04 upsj

Error: The following files need to be formatted:

core/solver/gcr.cpp
reference/solver/gcr_kernels.cpp
test/solver/gcr_kernels.cpp

You can find a formatting patch under Artifacts here or run format! if you have write access to Ginkgo

ginkgo-bot avatar Apr 14 '22 07:04 ginkgo-bot

Thanks @kho19 for your contribution. Before I get to reviewing, do you mind posting a literature reference for the algorithm you've implemented? It would also be nice to have that reference in the code documentation.

MarcelKoch avatar Apr 19 '22 13:04 MarcelKoch

GCR was based on the description in Iterative methods for sparse linear systems by Yousef Saad. I'll include this in the documentation.

kyrillh avatar Apr 20 '22 08:04 kyrillh