MHI-AC-Ctrl-ESPHome
MHI-AC-Ctrl-ESPHome copied to clipboard
Terminator nl master
Needs some testing, especially on the api room temp part and the offset / low temperature stuff from @Terminator-NL
Thanks for the continuing effort! I could have missed the context for a lot of these changes, but:
- The external room temperature sensor capability is removed in favor of a user configurable temperature offset or simulated room temperature?
- We are changing the .h and .cpp files now instead of copying them as-is from the MHI-AC-Ctrl project? Can we still easily pull changes from the MHI-AC-Ctrl project?
- What is the low temperature heating?
If I know what to look for I can test these changes and provide feedback here.
Edit: I found #83 :)
Hi @ervee thanks for replying and wanting to help.
the changes are indeed for issue #83 and the nice work of @TerminatorNL
- the external room temperature sensor capability was removed by @TerminatorNL but i readded it, so it should have both. as i don't use both yet, it is not easy for me to test this through.
- the files MHI-AC-Ctrl-core.cpp and MHI-AC-Ctrl-core.h are fetched from the MHI-AC-CTRl, and the changes here are cosmetic changes that came from "upstream". the file MHI-AC-Ctrl.h is "ours" and contains all logic, and is the part that was extended
- The units normaly don't allow for heating under 18 degrees celsius, or cooling above 30 degrees i think, this should allow for heating to for example 16 degrees
in future, we can extend it further to allow half degree setting of temperature (which currently is ignored)