Notes on this fork

[ginjo]

Here are some notes on this fork. I may edit this post as things change.

• I renamed my auth-hash-fixes branch to features-and-fixes, since the work I've done has expanded beyond the auth-hash object. If you delete & reload (re-bundle) my /ginjo/omniauth-slack fork from github, you should get the correct branch (features-and-fixes is the default branch of the fork). Or you can specify the branch explicitly.

  gem 'omniauth-slack', :git => 'https://github.com/ginjo/omniauth-slack.git', :branch => 'features-and-fixes'

• The entirety of my contributions to this gem can be found in the features-and-fixes branch of the /ginjo/omniauth-slack fork. The master branch of the fork is kept in tune with @kmrshntr 's master.

• I have not merged @kmrshntr 's master into my features-and-fixes branch, yet. I may add another branch for doing just that.

• I updated the gemspec deps in the features-and-fixes branch according to @kmrshntr master.

• In the features-and-fixes branch, as of the date of this post, all tests are passing (ruby 2.3.7p456 (2018-03-28 revision 63024) [x86_64-linux-musl]). I plan to add more tests to cover the work I've done.

• I originally (couple years ago) changed the info-hash key name for team_name to team. I can't remember why I did that, and I don't think it was a good move. I have changed that back to team_name now... appologies if it breaks your code.

• I will continue to refine my work and update my documentation (currently only found in the slack.rb file, probably not a good place for it, maybe better in the issues section of the forked repo).

• Time permitting, I would like to review Slack's API and the master omniauth-slack repo, and address any major outstanding issues. I also have an eye on some potential features (workspace tokens, I see you out there).

[ginjo]

Here is a description of the current branches in the ginjo fork.

• master ~~Basic mirror of kmrshntr/omniauth-slack master branch, generally up-to-date with kmrshntr, but not always~~. The master branch of this fork now contains my latest work and the most up-to-date readme for that work. It includes all the work from my other public branches, plus additional tweaks and fixes. This branch is now the default for the repository.

• features-and-fixes All the work I've done over the last couple of years, since I forked. This branch has not been merged in any way with kmrshntr's repo, since the fork was created.

• features-and-fixes-rebased All of my commits from the features-and-fixes branch, squashed and rebased on top of kmrshntr/master on 2018-07-25. ~~This is the branch I'll be making further commits to~~.

[ginjo]

Please note the master branch is now the default branch of this fork. It contains all of my previous work, cleaned up and better organized, and also contains some new fixes and features.

The most important addition is support for Workspace apps. See the updated readme for more info.

As of this writing, the ginjo master branch is merge-able, without errors, with @kmrshntr's master branch. Not trying to pressure anyone... just sayin 😄.

[ginjo]

I have released this fork as ginjo-omniauth-slack-2.4.0.gem on rubygems.org. Checkout the readme and changelog for more info.