cat-message icon indicating copy to clipboard operation
cat-message copied to clipboard

Published 20 hours ago • verified publisher icon ginglis13

Add YouTube support

Open MasterOfTheTiger opened this issue 5 years ago • 7 comments

This closes #3. There are a couple things you may want to change though.

MasterOfTheTiger avatar Oct 05 '19 16:10 MasterOfTheTiger

So sorry. This is embarrassing. I really screwed this up. I shouldn't program when I am tired. Tomorrow it will work.

MasterOfTheTiger avatar Oct 06 '19 16:10 MasterOfTheTiger

@ginglis13 Now this is ready for review!

You should probably squash merge this when ready because of my mistake.

MasterOfTheTiger avatar Oct 08 '19 16:10 MasterOfTheTiger

A little busy today but I'll take a look later this afternoon - thanks ! :)

ginglis13 avatar Oct 09 '19 14:10 ginglis13

@MasterOfTheTiger This is great! Looks like it downloads a youtube video to the current directory and names it cat.mp4. Just a small request or two: The line os.unlink('cat.mp4') could be problematic if the file cat.mp4 does not exist (because oftentimes media types are .jpg or .gif). Maybe just move the call to get_yt to be below the current handling of this unlinking. (or unlink earlier in the function).

ginglis13 avatar Oct 10 '19 02:10 ginglis13

Okay. I understand. I'll do that later.

MasterOfTheTiger avatar Oct 10 '19 07:10 MasterOfTheTiger

@ginglis13 It is now ready.

MasterOfTheTiger avatar Oct 12 '19 13:10 MasterOfTheTiger

@ginglis13, I realize you are busy, but you may want to see what I did and test it for yourself.

MasterOfTheTiger avatar Oct 29 '19 18:10 MasterOfTheTiger