Emil Eriksson

Results 15 comments of Emil Eriksson

An alternative, or additional nice thing to have, would be occasional prints to the console of the running total. Like after every `n` connected clients, print the total data transfer...

@yunginnanet I can take a look later if you want a sanity check? Go isn't my first language but two sets of eyeballs is always nice

I should have ran the doctests... Marked as `ignore` since I don't think it's possible to access the directive structs from doctests without changing their visibility. This means someone should...

Thank you for taking the time to review!

Sorry about the CI, have added ` "editor.formatOnSave": true` now... I have tried, based on `demo-hackernews`, to provide adequate examples and explanations for some of the adapter methods. However, I...

> Yes, agreed. I realized a design like https://github.com/obi1kenobi/trustfall/pull/131 is necessary because the hint parameters are technically all you need but in practice are just waaay too tedious to use....

I think you're on the right track. This new `trustfall` crate could simply be an interface, and `trustfall_core` could be a library hiding the magic. One thing I think we...

One thing that came to mind might be the inclusion of parsers. Right now the `graphql_*` things are part of `trustfall_core`, but maybe parsers should be decided by feature-flags? Or...

(This should probably have its own issue) Perhaps we could consider moving it to `trustfall_core/examples` instead? It would need some reorganizing (but nothing major). The [cargo book](https://doc.rust-lang.org/cargo/reference/cargo-targets.html?highlight=example#examples) has some information....