fiware-idm icon indicating copy to clipboard operation
fiware-idm copied to clipboard

Fixed serviceproviders 500 status

Open Jxlle opened this issue 1 year ago • 2 comments

Proposed changes

When using the internal Keyrock authorization registry, it is possible to request whether a subject has the access rights to execute a specific action on a specific resource. Service providers which are allowed to provide services to the subject can also be configured, but querying on this attribute throws an error and returns status code 500 to the user of the api. This PR changes a non-existent method (has) to its implemented equivalent (includes), such that the code doesn't crash anymore.

Types of changes

  • [x] Bugfix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • [x] I have read the CONTRIBUTING doc
  • [x] I have signed the CLA
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] I have added necessary documentation (if appropriate)
  • [ ] Any dependent changes have been merged and published in downstream modules

Further comments

Problem can also be seen in this forum post: https://spaces.fundingbox.com/spaces/i4trust-i4trust-helpdesk/648daadfb958a4312734000c

Jxlle avatar Jul 04 '23 13:07 Jxlle

CLA Assistant Lite bot All contributors have signed the CLA ✍️

github-actions[bot] avatar Jul 04 '23 13:07 github-actions[bot]

+1. Just encounted this issue as well and the fix fixes it

MarkusPfundstein avatar Jul 17 '23 19:07 MarkusPfundstein