gin icon indicating copy to clipboard operation
gin copied to clipboard

avoid double unescaping

Open AgNess-G opened this issue 1 month ago • 6 comments

this is to resolve - https://github.com/gin-gonic/gin/issues/4443

Pull Request Checklist

Please ensure your pull request meets the following requirements:

  • [x] Open your pull request against the master branch.
  • [x] All tests pass in available continuous integration systems (e.g., GitHub Actions).
  • [x] Tests are added or modified as needed to cover code changes.
  • [ ] If the pull request introduces a new feature, the feature is documented in the docs/doc.md.

Thank you for contributing!

AgNess-G avatar Nov 21 '25 13:11 AgNess-G

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 96.36%. Comparing base (3dc1cd6) to head (f8b6b4a). :warning: Report is 226 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4447      +/-   ##
==========================================
- Coverage   99.21%   96.36%   -2.85%     
==========================================
  Files          42       44       +2     
  Lines        3182     2975     -207     
==========================================
- Hits         3157     2867     -290     
- Misses         17       87      +70     
- Partials        8       21      +13     
Flag Coverage Δ
?
--ldflags="-checklinkname=0" -tags sonic 96.34% <100.00%> (?)
-tags go_json 96.27% <100.00%> (?)
-tags nomsgpack 96.31% <100.00%> (?)
go-1.18 ?
go-1.19 ?
go-1.20 ?
go-1.21 ?
go-1.24 96.36% <100.00%> (?)
go-1.25 96.36% <100.00%> (?)
macos-latest 96.36% <100.00%> (-2.85%) :arrow_down:
ubuntu-latest 96.36% <100.00%> (-2.85%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Nov 24 '25 12:11 codecov[bot]

@appleboy Can you please help me understand the reason of these pre-check failures?

AgNess-G avatar Nov 25 '25 05:11 AgNess-G

@appleboy can you take a look please

AgNess-G avatar Nov 28 '25 11:11 AgNess-G

@Agnes-George Please revert the changes to gin.yml

appleboy avatar Nov 30 '25 07:11 appleboy

@appleboy can you take a look please

AgNess-G avatar Dec 02 '25 05:12 AgNess-G

hey @appleboy or anyone, please help me with this PR.

AgNess-G avatar Dec 08 '25 05:12 AgNess-G

@appleboy, @thinkerou, @javierprovecho can you review this code please

AgNess-G avatar Dec 11 '25 05:12 AgNess-G