gin icon indicating copy to clipboard operation
gin copied to clipboard

ci(testing): add go1.22 version

Open appleboy opened this issue 1 year ago • 2 comments

  • Update the version of gin to v1.56.1 in the .github/workflows/gin.yml file
  • Add go version 1.22 to the list of supported versions in the .github/workflows/gin.yml file

appleboy avatar Feb 12 '24 07:02 appleboy

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (3dc1cd6) 99.21% compared to head (05c8205) 99.36%. Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3842      +/-   ##
==========================================
+ Coverage   99.21%   99.36%   +0.15%     
==========================================
  Files          42       43       +1     
  Lines        3182     2676     -506     
==========================================
- Hits         3157     2659     -498     
+ Misses         17        9       -8     
  Partials        8        8              
Flag Coverage Δ
?
-race ∅ <ø> (?)
-tags "sonic avx" 99.35% <ø> (?)
-tags go_json 99.35% <ø> (?)
-tags nomsgpack 99.35% <ø> (?)
go-1.18 99.28% <ø> (+0.16%) :arrow_up:
go-1.19 99.36% <ø> (+0.15%) :arrow_up:
go-1.20 99.36% <ø> (+0.15%) :arrow_up:
go-1.21 99.36% <ø> (+0.15%) :arrow_up:
go-1.22 99.36% <ø> (?)
macos-latest 99.36% <ø> (+0.15%) :arrow_up:
ubuntu-latest 99.36% <ø> (+0.15%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 12 '24 07:02 codecov[bot]

On gin.yml line 77 it mentions go-version == '1.21.x', shouldn't that also be changed to 1.22.x? https://github.com/gin-gonic/gin/blob/bb3519d26f52835cf00e5e430b52651a9c378c97/.github/workflows/gin.yml#L77

the-eduardo avatar Feb 14 '24 18:02 the-eduardo

@the-eduardo Fixed in 59fc7c7

appleboy avatar Feb 18 '24 07:02 appleboy

@thinkerou Please help to review.

appleboy avatar Feb 18 '24 07:02 appleboy