gin icon indicating copy to clipboard operation
gin copied to clipboard

Check reader if it's nil before reading

Open noahyao1024 opened this issue 2 years ago • 2 comments

  • With pull requests:
    • Open your pull request against master
    • Your pull request should have no more than two commits, if not you should squash them.
    • It should pass all tests in the available continuous integration systems such as GitHub Actions.
    • You should add/modify tests to cover your proposed code changes.
    • If your pull request contains a new feature, please document it on the README.

noahyao1024 avatar Nov 30 '22 04:11 noahyao1024

@noahyao1024 Please add some testing flow.

appleboy avatar Dec 01 '22 05:12 appleboy

Codecov Report

Merging #3419 (a0ea288) into master (80cd679) will decrease coverage by 0.09%. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #3419      +/-   ##
==========================================
- Coverage   98.27%   98.18%   -0.10%     
==========================================
  Files          42       42              
  Lines        3137     3140       +3     
==========================================
  Hits         3083     3083              
- Misses         40       42       +2     
- Partials       14       15       +1     
Flag Coverage Δ
98.18% <0.00%> (-0.10%) :arrow_down:
go-1.16 ?
go-1.17 98.08% <0.00%> (-0.10%) :arrow_down:
go-1.18 98.08% <0.00%> (-0.10%) :arrow_down:
go-1.19 98.18% <0.00%> (-0.10%) :arrow_down:
macos-latest 98.08% <0.00%> (-0.19%) :arrow_down:
ubuntu-latest 98.18% <0.00%> (-0.10%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
context.go 97.47% <0.00%> (-0.50%) :arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Dec 01 '22 05:12 codecov[bot]