gin icon indicating copy to clipboard operation
gin copied to clipboard

Add support go 1.19

Open mstmdev opened this issue 1 year ago • 2 comments

mstmdev avatar Aug 07 '22 18:08 mstmdev

Codecov Report

Merging #3272 (e9369dd) into master (6296175) will increase coverage by 0.09%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3272      +/-   ##
==========================================
+ Coverage   98.27%   98.36%   +0.09%     
==========================================
  Files          42       42              
  Lines        3124     3124              
==========================================
+ Hits         3070     3073       +3     
+ Misses         40       38       -2     
+ Partials       14       13       -1     
Flag Coverage Δ
98.36% <ø> (+0.09%) :arrow_up:
go-1.16 ∅ <ø> (∅)
go-1.17 98.27% <ø> (ø)
go-1.18 98.27% <ø> (ø)
go-1.19 98.36% <ø> (?)
macos-latest 98.36% <ø> (+0.09%) :arrow_up:
ubuntu-latest 98.36% <ø> (+0.09%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
context.go 98.46% <0.00%> (+0.51%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Aug 07 '22 18:08 codecov[bot]

Please consider raising the priority, our gin-gonic based apps are now being flagged because of the net/http vulnerability affecting go versions before 1.19.1 - https://www.mend.io/vulnerability-database/CVE-2022-27664

barshociaj avatar Sep 20 '22 12:09 barshociaj

Please approve.

wgd-ah avatar Sep 21 '22 19:09 wgd-ah

Please approve. Failing govulncheck:

Vulnerability #1: GO-2022-0969
  HTTP/2 server connections can hang forever waiting for a clean
  shutdown that was preempted by a fatal error. This condition can
  be exploited by a malicious client to cause a denial of service.
  
  Found in: [golang.org/x/net/[email protected]](http://golang.org/x/net/[email protected])
  Fixed in: [golang.org/x/net/[email protected]](http://golang.org/x/net/[email protected])
  More info: https://pkg.go.dev/vuln/GO-2022-0969

kevdoan avatar Sep 21 '22 20:09 kevdoan

Please approve. Failing govulncheck:

Vulnerability #1: GO-2022-0969
  HTTP/2 server connections can hang forever waiting for a clean
  shutdown that was preempted by a fatal error. This condition can
  be exploited by a malicious client to cause a denial of service.
  
  Found in: [golang.org/x/net/[email protected]](http://golang.org/x/net/[email protected])
  Fixed in: [golang.org/x/net/[email protected]](http://golang.org/x/net/[email protected])
  More info: https://pkg.go.dev/vuln/GO-2022-0969

Update golang.org/x/net module requires Go 1.16, need remove Go 1.15 support.

mstmdev avatar Sep 22 '22 06:09 mstmdev

@mstmdev we should remove support go1.15 next version v1.19.

appleboy avatar Oct 11 '22 07:10 appleboy

I've hit test failures with v1.8.1 while refreshing the Debian package, since Go is currently at 1.19 in Debian unstable/testing.

Since the proposed branch contains a bunch of merges and unrelated changes, I've crafted a patch that adds the new file for 1.19, and that disables the 1.17 one via build restrictions.

You'll find it attached for reference, keeping it mind it's only tested against Go 1.19. 0004-test-suite-add-support-for-Go-1.19.patch.txt

CyrilBrulebois avatar Oct 11 '22 08:10 CyrilBrulebois

@mstmdev we should remove support go1.15 next version v1.19.

Remove go1.15 support #3361

mstmdev avatar Oct 12 '22 14:10 mstmdev

@thinkerou Please help to review.

appleboy avatar Oct 13 '22 02:10 appleboy

@thinkerou Please help to review.

lgtm

thinkerou avatar Oct 13 '22 08:10 thinkerou