gin
gin copied to clipboard
Fix redirectSlash bug
fixes #2959 fixes #2282 fixes #2211
code from https://github.com/julienschmidt/httprouter/pull/342
please review @appleboy thanks!
Codecov Report
Merging #3227 (3b8c932) into master (12b55b4) will increase coverage by
0.16%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## master #3227 +/- ##
==========================================
+ Coverage 98.22% 98.38% +0.16%
==========================================
Files 43 43
Lines 3148 3153 +5
==========================================
+ Hits 3092 3102 +10
+ Misses 44 38 -6
- Partials 12 13 +1
Flag | Coverage Δ | |
---|---|---|
go-1.14 | ? |
|
go-1.15 | 98.38% <100.00%> (+0.32%) |
:arrow_up: |
go-1.16 | 98.35% <100.00%> (+0.32%) |
:arrow_up: |
go-1.17 | 98.28% <100.00%> (+0.32%) |
:arrow_up: |
go-1.18 | 98.28% <100.00%> (+0.32%) |
:arrow_up: |
macos-latest | 98.38% <100.00%> (+0.16%) |
:arrow_up: |
nomsgpack | 98.35% <100.00%> (+0.16%) |
:arrow_up: |
ubuntu-latest | 98.38% <100.00%> (+0.16%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
tree.go | 100.00% <100.00%> (ø) |
|
debug.go | 91.66% <0.00%> (-8.34%) |
:arrow_down: |
context.go | 98.46% <0.00%> (+1.70%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 12b55b4...3b8c932. Read the comment docs.
please review @appleboy thanks!
hope this will be merged soon, our team is having difficulties in a production environment because of this bug
@thinkerou maybe create a new tag for a bug fix?
@thinkerou, @appleboy our team is also waiting for this fix. Creating new version would be very helpful. Thanks
@thinkerou maybe create a new tag for a bug fix?
yes 👍
Also waiting on this.
we will release the feature in v1.8.2
@thinkerou See the milestone: https://github.com/gin-gonic/gin/milestone/23
https://github.com/gin-gonic/gin/releases/tag/v1.8.2