gin
gin copied to clipboard
add an option to have the default value as a list with commas as seperator
-
[x] Open your pull request against
master -
[x] Your pull request should have no more than two commits, if not you should squash them.
-
[x] It should pass all tests in the available continuous integration systems such as TravisCI.
-
[x] You should add/modify tests to cover your proposed code changes.
-
[x] If your pull request contains a new feature, please document it on the README.
The idea was like mentioned on the title to be able to specify multiple default values that will come back as a slice
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 98.70%. Comparing base (
6703dea) to head (2e7b385). Report is 337 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #2744 +/- ##
=======================================
Coverage 98.69% 98.70%
=======================================
Files 41 41
Lines 2074 2079 +5
=======================================
+ Hits 2047 2052 +5
Misses 15 15
Partials 12 12
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@appleboy Hi, can we get this PR merged since it was already approved? (I can make a copy of this PR with conflicts fixed if that's the only blocker to getting this released publicly)