RedirectFixedPath redirecting trailing slashes

[japettyjohn]

Description

RedirectFixedPath is redirecting trailing slashes regardless of the RedirectTrailingSlash setting.

In gin.go there is a comment that the RedirectTrailingSlash is independent, but then the comment does not indicate that the behavior would be to also redirect trailing slashes in RedirectFixedPath always. If it's the intended behavior then the comment should be clarified.

If it's not the intended behavior then the trouble is in gin.go where it uses engine.RedirectFixedPath for the trailingSlash parameter, which is always going to evaluate to true in where RedirectFixedPath is in use.

How to reproduce

package main

import (
	"fmt"
	"net/http/httptest"

	"github.com/gin-gonic/gin"
)

func main() {
	r := gin.Default()
	r.RedirectTrailingSlash = false
	r.RedirectFixedPath = true
	r.GET("/ping", func(c *gin.Context) {
		c.String(200, "pong")
	})

	resp := httptest.NewRecorder()
	r.ServeHTTP(resp, httptest.NewRequest("GET", "/ping/", nil))
	fmt.Println(resp.Result().StatusCode, resp.Header().Get("Location"))
}

Expectations

$ curl localhost:8080/ping/
404 page not found

Actual result

$ curl localhost:8080/ping/
<a href="/ping">Moved Permanently</a>.

Environment

• go version: go version go1.13.8 darwin/amd64
• gin version (or commit ref): v1.5.0
• operating system: macOS High Sierra

[aleimu]

+1