gin icon indicating copy to clipboard operation
gin copied to clipboard

fix(ginMode): data race warning

Open kplachkov opened this issue 7 years ago • 7 comments

Added atomic operations.
Fixes #1180

kplachkov avatar Oct 01 '18 18:10 kplachkov

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.18%. Comparing base (3dc1cd6) to head (3bd58a8). Report is 46 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1580      +/-   ##
==========================================
- Coverage   99.21%   99.18%   -0.03%     
==========================================
  Files          42       43       +1     
  Lines        3182     2714     -468     
==========================================
- Hits         3157     2692     -465     
+ Misses         17       12       -5     
- Partials        8       10       +2     
Flag Coverage Δ
?
-tags "sonic avx" 99.18% <100.00%> (?)
-tags go_json 99.18% <100.00%> (?)
-tags nomsgpack 99.17% <100.00%> (?)
go-1.18 99.11% <100.00%> (-0.01%) :arrow_down:
go-1.19 99.18% <100.00%> (-0.03%) :arrow_down:
go-1.20 99.18% <100.00%> (-0.03%) :arrow_down:
go-1.21 99.18% <100.00%> (-0.03%) :arrow_down:
go-1.22 99.18% <100.00%> (?)
macos-latest 99.18% <100.00%> (-0.03%) :arrow_down:
ubuntu-latest 99.18% <100.00%> (-0.03%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Oct 01 '18 19:10 codecov[bot]

It's updated

kplachkov avatar May 07 '19 11:05 kplachkov

@kplachkov can you add some test case according https://github.com/gin-gonic/gin/issues/1180#issue-276448495 thanks!

thinkerou avatar May 19 '19 14:05 thinkerou

May I ask about the reason this PR still cannot be merged? Thanks!

vuon9 avatar Feb 19 '21 12:02 vuon9

It's been a while, any news please?

plo- avatar Mar 06 '23 14:03 plo-

I also meet the same problem, when will it be merged?

lhy1024 avatar Nov 28 '23 04:11 lhy1024

@kplachkov Please help to resolve conflicts.

appleboy avatar Dec 07 '23 06:12 appleboy

@kplachkov Thanks.

appleboy avatar May 08 '24 01:05 appleboy

7 years ? ahahahahahh

mymtw avatar May 08 '24 18:05 mymtw