gin icon indicating copy to clipboard operation
gin copied to clipboard

support chunked encoding

Open thinkerou opened this issue 7 years ago • 9 comments

ref: #1443

thinkerou avatar Aug 20 '18 12:08 thinkerou

Codecov Report

Merging #1501 (04eb752) into master (dfc25f9) will decrease coverage by 0.50%. The diff coverage is 20.00%.

@@            Coverage Diff             @@
##           master    #1501      +/-   ##
==========================================
- Coverage   98.75%   98.25%   -0.51%     
==========================================
  Files          41       43       +2     
  Lines        3059     3834     +775     
==========================================
+ Hits         3021     3767     +746     
- Misses         26       53      +27     
- Partials       12       14       +2     
Flag Coverage Δ
go-1.13 97.89% <0.00%> (-0.87%) :arrow_down:
go-1.14 97.73% <0.00%> (-0.87%) :arrow_down:
go-1.15 98.12% <20.00%> (-0.48%) :arrow_down:
go-1.16 98.11% <20.00%> (-0.48%) :arrow_down:
go-1.17 97.44% <24.00%> (?)
go-1.18 97.44% <24.00%> (?)
macos-latest 98.25% <20.00%> (-0.51%) :arrow_down:
nomsgpack 98.22% <20.00%> (-0.52%) :arrow_down:
ubuntu-latest 98.25% <20.00%> (-0.51%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
render/reader.go 58.06% <0.00%> (-41.94%) :arrow_down:
render/render.go 100.00% <ø> (ø)
context.go 97.60% <35.29%> (-0.38%) :arrow_down:
mode.go 100.00% <0.00%> (ø)
tree.go 100.00% <0.00%> (ø)
routergroup.go 100.00% <0.00%> (ø)
binding/form.go 100.00% <0.00%> (ø)
binding/header.go 100.00% <0.00%> (ø)
binding/binding.go 100.00% <0.00%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update dfc25f9...04eb752. Read the comment docs.

codecov[bot] avatar Sep 25 '18 14:09 codecov[bot]

Add unit testing?

appleboy avatar Jun 11 '20 16:06 appleboy

@appleboy @javierprovecho Any chance to have that feature merge into the master? Would be very helpful when the content size is unknown in advance (which is our case when fetching rows from a database). Thank you

niolap avatar Aug 12 '20 09:08 niolap

@thinkerou Please add unit testing.

appleboy avatar Aug 12 '20 13:08 appleboy

@thinkerou Please add unit testing.

@thinkerou, If you can do that, you'll make my day

niolap avatar Aug 12 '20 14:08 niolap

Hi 👋 Any updates to this PR? I could complete the requested changes if required.

yashrsharma44 avatar Aug 19 '21 15:08 yashrsharma44

  1. fix conflicts.
  2. add unit testing.

appleboy avatar Aug 20 '21 00:08 appleboy

Hi 👋 Any updates to this PR? I could complete the requested changes if required.

@yashrsharma44 please, thanks a lot!!!

thinkerou avatar Aug 22 '21 12:08 thinkerou

@thinkerou Add some testing case?

appleboy avatar Mar 21 '24 13:03 appleboy