sessions icon indicating copy to clipboard operation
sessions copied to clipboard

delete context.Clear and dependency to gorilla/context

Open KeiichiHirobe opened this issue 2 years ago • 0 comments

defer context.Clear(c.Request) does not make sense now because this library depends on github.com/gorilla/sessions v1.2.0.

So delete defer context.Clear(c.Request) and, go mod tidy to delete dependency to gorilla/context(UPDATE: https://github.com/gin-contrib/sessions/pull/131 made a new dependency to github.com/wader/gormstore/[email protected], which depends on gorilla context, so gorilla/context still exists in go.sum ).

If version is lower than v1.2.0, we need this code to avoid memory leak. ref: https://github.com/gorilla/sessions/pull/175

Resolve: https://github.com/gin-contrib/sessions/issues/92

KeiichiHirobe avatar Mar 19 '22 04:03 KeiichiHirobe