logger icon indicating copy to clipboard operation
logger copied to clipboard

Add benchmark

Open cedric-appdirect opened this issue 1 year ago • 3 comments

This should help for #69 and #76 and future PR that could affect performance.

cedric-appdirect avatar Jan 08 '24 23:01 cedric-appdirect

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.78%. Comparing base (d96c742) to head (60bff74). Report is 8 commits behind head on master.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #77      +/-   ##
==========================================
+ Coverage   94.24%   94.78%   +0.53%     
==========================================
  Files           2        2              
  Lines         139      115      -24     
==========================================
- Hits          131      109      -22     
+ Misses          5        3       -2     
  Partials        3        3              
Flag Coverage Δ
go- 94.78% <ø> (+0.53%) :arrow_up:
go-1.18 94.78% <ø> (+0.53%) :arrow_up:
go-1.19 94.78% <ø> (+0.53%) :arrow_up:
go-1.20 94.78% <ø> (+0.53%) :arrow_up:
go-1.21 94.78% <ø> (+0.53%) :arrow_up:
go-1.22 94.78% <ø> (+0.53%) :arrow_up:
macos-latest 94.78% <ø> (+0.53%) :arrow_up:
ubuntu-latest 94.78% <ø> (+0.53%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Jan 08 '24 23:01 codecov-commenter

Checking the raw logs, it seems even if I set permission for PR to write, it isn't taken into account. From reading around, it seems it would only switch it to write if it get merged into master first, but I am not certain of that. No idea how to tests this further at the moment.

cedric-appdirect avatar Jan 09 '24 00:01 cedric-appdirect

Seems you need to check your Settings > Actions > General > Workflow permissions, and make sure to enable read and write permissions for this action to actually work.

cedric-appdirect avatar Apr 16 '24 22:04 cedric-appdirect