Refactor tests to use test-assembler

[fitzgen]

It is more readable and less error prone (especially when updating tests and changing the length of some sequence of bytes!) than the old style of writing things out by hand.

We can do this piecemeal, no need to port all tests over at once.

See also #121, which will be very helpful for this work.

[philipc]

Mostly done. I think the main thing left is some examples in unit.rs. I'm not sure of the value of using those examples as tests. Maybe they can be simplified to code that simply compiles, rather than runs.

[fitzgen]

Agreed. Now that we have thorough unit tests, the doc tests can focus on being examples, rather than tests.

On Nov 29, 2016 1:47 AM, "Philip Craig" [email protected] wrote:

Mostly done. I think the main thing left is some examples in unit.rs. I'm not sure of the value of using those examples as tests. Maybe they can be simplified to code that simply compiles, rather than runs.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/gimli-rs/gimli/issues/122#issuecomment-263524035, or mute the thread https://github.com/notifications/unsubscribe-auth/AAEjS4IQ4z03W5DZIHcXgA0tBe-qwCbBks5rC_SagaJpZM4KBztz .