capacitor icon indicating copy to clipboard operation
capacitor copied to clipboard

Typescript conversion

Open SorsOps opened this issue 1 year ago • 2 comments

Changes

  • Convert to typescript
  • Replace capacitorClient propdrilling with context
  • Add types from kubernetes
  • Group widgets and event handlers together
  • Minor cleanup for props that were not used, such as showMessage on the widgets
  • Replace classnames with npm package

I will handle merge conflicts if the other PRs are approved and merged in

SorsOps avatar Apr 14 '24 12:04 SorsOps

Typescript is a big jump. At least in my head. Please allow me some time to make up my mind about it.

laszlocph avatar Apr 15 '24 07:04 laszlocph

No problem, I think it will be necessary for this project to attract additional contributors and for this to be considered a mature project and gain adoption. I really would like this to eclipse ArgoCD.

It did help to find some of the issues such as the non standard date parsing, the fact that some dates are being compared to numbers, and some of issues with prop passing, so I do think it has value

SorsOps avatar Apr 15 '24 09:04 SorsOps