bilt
bilt copied to clipboard
Show "# of #" in progress and header reports
When showing progress or headers like these:
**** [packages/metacritic-product-catalog-deploy] building
then show how many packages there are, and which build it is. Somethign like
**** [packages/metacritic-product-catalog-deploy] building (2 of 4)
How to:
This should happen in command-build.js
in the package cli
. The outputting happens in makePackageBuild
which is a function that returns a function, so it's not trivial, but it could go like this:
- Pass the length of the array of packages to the
makePackageBuild
function so that it can output how many packages there are, thus taking care of "building (? of <number-of-packages)". - The index of the package is more difficult, because the build of the package happens in the anonymous function returned by
makePackageBuild
, and the only thing passed to it is the package info. And that anonymous function is called by thebuild
package, which we don't want to change. To deal with that, we'll needbuildPackages
to pass it the index of the current package being built by modifying its loop to also increment an index, and passing that index to the buildPackage func.
this issue can be a starting point to the progress one? (issue #36 ) ?
@yanai101 I can see one PR dealing with both of them. They're pretty similar.
I can try to deal with theme, for starting to understand the system
@yanai101 feel free to assign yourself to this.
@giltayar I can't assign this to me... - I think only you can assign issues ... - or am I wrong?
Probably. @yanai101 I assigned you!