Cumulus icon indicating copy to clipboard operation
Cumulus copied to clipboard

Windows support

Open MichielDeMey opened this issue 9 years ago • 4 comments

We're looking into fully supporting Windows, but we currently have some issues that need to be resolved.

Development is tracked in the following branch: https://github.com/gillesdemey/Cumulus/tree/dev-windows

  • [x] Add Windows build to build Windows binaries
  • [x] Add Windows setup generator
  • [ ] Fix media keys not working on Windows
  • [x] Fix crash when right-clicking the icon

We'll extend this list when more issues are found.

MichielDeMey avatar Sep 06 '15 16:09 MichielDeMey

To support media keys on Windows we might want to look at App Commands.
https://github.com/atom/electron/blob/master/docs/api/browser-window.md#event-app-command-windows

MichielDeMey avatar Sep 06 '15 16:09 MichielDeMey

Hmm, I'm pretty sure the WM_APPCOMMAND notification is only sent to the window that is active.

https://github.com/atom/electron/blob/master/docs/api/global-shortcut.md looks more promising imo.

seppestas avatar Sep 07 '15 10:09 seppestas

We're already using global-shortcut https://github.com/gillesdemey/Cumulus/blob/7a8eb12924e32833584ada1f6c153cdddf3ed611/index.js#L94-L104

They're not working on Windows however, we need to figure out why and possibly look into alternatives.

gillesdemey avatar Sep 07 '15 13:09 gillesdemey

Pff, I'll never get this fixed in time for Hacktoberfest XD

seppestas avatar Oct 31 '16 20:10 seppestas