ocaml-fileutils icon indicating copy to clipboard operation
ocaml-fileutils copied to clipboard

AskFollow's function result is interpreted differently than documented

Open gildor478 opened this issue 4 years ago • 0 comments

This bug has been migrated from artifact #1302 on forge.ocamlcore.org. It was assigned to user100.

user112 posted on 2013-08-01 19:09:32:

A function passed into FileUtil.find's ~follow parameter with the AskFollow constructor is logically flipped from what the documentation states. The documentation states that a file will be skipped if the function's return value is false. In the code however a true return value indicates that the given link should be skipped.

user148 replied on 2013-10-05 11:30:33:

In my current patch for bug #712, I change the behaviour of AskFollow so that "true" means "follow" (i.e. like the doc states).

I'd like to be sure which behaviour is the right one.

(I hadn't noticed that issue and only changed it because I rewrote the relevant function instead of copying it)

gildor478 avatar Oct 24 '20 15:10 gildor478