chef-android-sdk icon indicating copy to clipboard operation
chef-android-sdk copied to clipboard

Add macOS support; Add Windows support; And more...

Open rjaros87 opened this issue 7 years ago • 16 comments

Major changes:

  • Added Windows support
  • Added ServerSpec test #5
  • Added chefignore file #30

Minor changes:

  • Unsupport Centos OS < 7 due to Android SDK use GNU C Library (glibc) 2.14 or later
  • Cleanup default['android-sdk']['components']

rjaros87 avatar Jul 24 '16 11:07 rjaros87

@gildegoma please review. Pull request #32 is necessary for this PR

rjaros87 avatar Jul 24 '16 11:07 rjaros87

@rjaros87 @Brantone Sorry guys for being so unresponsive... This PR contains a lot of different things, making the review more difficult and time consuming (and I lack of large bunch of spare time).

I'll do my best to reserve some time for starting soon though. Do you have by the way some good Packer templates to build local VMs for testing on Windows and Mac (Virtualbox, Parallels or VMware welcome, or recommendation for a good Cloud provider, ideally well supported by Vagrant plugin ecosystem)? ❤️ ❤️ ❤️

gildegoma avatar Jan 25 '17 09:01 gildegoma

@gildegoma I use Vagrant + VirtualBox (with extension pack) and Kitchen :) as you know everything is in .kitchen.yml

For testing Windows you need also Vagrant plugin for WinRM vagrant plugin install vagrant-winrm

rjaros87 avatar Jan 25 '17 16:01 rjaros87

@rjaros87 Sorry, I missed the fact that your last commit (04dd45b) added two new kitchen boxes (mac_el_capitan and windows-2012R2). I'll test all this together, but as already said, I appreciate if in the future you can please create PR focused on a single specific addition. Looking forward though, thanks again for all the work and your patience 💟

gildegoma avatar Jan 25 '17 16:01 gildegoma

@gildegoma #29 - 7 file to review #32 15 files - 7 files = 8 files to review this #33 20 files - 15files = 5 files to review

rjaros87 avatar Jan 25 '17 17:01 rjaros87

@gildegoma ready to review. Please close other pull request and make review this one.

rjaros87 avatar Feb 02 '17 09:02 rjaros87

Thank you @rjaros87 for all these propositions. As mentionned, having all these different things packed together is not the ideal way to get things merged quickly. I really value your efforts and work, and will do my best to do this review "asap", and hopefully take in most (if not all) your changes.

Here is a short and recent article about the "hard work" to maintain stable projects: https://www.jeffgeerling.com/blog/2016/why-i-close-prs-oss-project-maintainer-notes

But as already said above, I'm glad you made all this work and I am looking forward to integrate it here ❤️ ❤️ ❤️

gildegoma avatar Feb 02 '17 09:02 gildegoma

@gildegoma did you disable travis tests? After merge with above branch, nothing triggered.

rjaros87 avatar Mar 04 '17 13:03 rjaros87

@rjaros87 Yup, I temporarily disabled Travis CI (see #37) to avoid generating broken builds while preparing 0.2.1 release. This is active again. Please rebase onto an updated master and repush. The build should start again...

gildegoma avatar Mar 04 '17 15:03 gildegoma

Please review my last changes. @gildegoma maybe you should create a 0.2 branch from master and merge this PR. What do you think? Because it's hard to maintain and resolve conflicts. In some commits you done the same as I couple months ago.

rjaros87 avatar Mar 05 '17 10:03 rjaros87

Whats the status on this? Would be nice to use it from the supermarket.

joshrlesch avatar Aug 15 '17 15:08 joshrlesch

Adding my voice (again) to the "status?" pile.

Brantone avatar Oct 18 '17 21:10 Brantone

@gildegoma Been a long while since this has been open ... what can be done to move it along?

Brantone avatar May 10 '18 22:05 Brantone

Anyone?

Brantone avatar Jul 28 '18 07:07 Brantone

Only @gildegoma could merge this, no one have a permissions. Let say, I'm no more involved with Chef, so this is my last commit ;)

rjaros87 avatar Jul 30 '18 05:07 rjaros87

@gildegoma ?

Brantone avatar Apr 18 '19 22:04 Brantone