dark-mode-sync-plugin icon indicating copy to clipboard operation
dark-mode-sync-plugin copied to clipboard

Not working with Catalina Auto mode

Open tgatz opened this issue 5 years ago • 7 comments

First of all thank you for the great work on this plugin, but unfortunately it seems that it is not working when Auto Mode is enabled in MacOS Catalina.

Maybe this could help https://forums.developer.apple.com/thread/118974

tgatz avatar Jan 09 '20 09:01 tgatz

I'm on that.

kannicht avatar Jan 09 '20 23:01 kannicht

I just tested the issue. I don't see any malfunction in the automatic mode.

I tried to reproduce the error as following:

  1. Start IDE
  2. Check Auto Theme Change in MacOS enabled.
  3. Change timezone to a Timezone currently in daylight and back.

After these steps, the plugin behaved well both in the current release version and in the future release.

kannicht avatar Jan 10 '20 00:01 kannicht

Works for me.

Sottti avatar Jan 10 '20 09:01 Sottti

I'm running into the same issue when starting my Mac in daylight after powering it down in the evening.

Reproduction:

  • Set appearance to "auto"
  • Power down computer (currently dark)
  • Start up (daylight)
  • Dark theme is enabled until toggling the appearance Auto -> Light -> Auto

Notice: I'm syncing my setting to a GitHub repository, maybe this is causing the issue

romanzipp avatar Jan 21 '20 11:01 romanzipp

The link @atomiko posted is a good start. Doing some experimenting of my own, and I'm getting different results than the author of that post. The post includes this logic:

   if UserDefaults(AppleInterfaceStyleSwitchesAutomatically) == TRUE  
      if UserDefaults(AppleInterfaceStyle) == NIL≤  
         theme = dark // is nil, means it's dark and will switch in future to light       
      else  
         theme = light //means it's light and will switch in future to dark  
      endif 

But in my environment, UserDefaults(AppleInterfaceStyleSwitchesAutomatically) can be true and UserDefaults(AppleInterfaceStyle) returns Dark. I need to do a bit more experimenting before I'm sure how to factor "Auto" mode into the dark mode detection.

gilday avatar Jan 22 '20 02:01 gilday

I'm running into the same issue when starting my Mac in daylight after powering it down in the evening.

I'm having the same problem @romanzipp

Tyranwyn avatar Mar 27 '20 08:03 Tyranwyn

Having similar trouble with Mac OS Catalina auto mode. It works fine when the dark/light mode changes while Webstorm is running. In the evening I shuted down in dark mode and in the morning I started in light mode but webstorm was still in dark theme. Even if I manually changed the theme to be light, it automatically changed back to dark again.

taurni avatar Oct 16 '20 07:10 taurni