SingleFile icon indicating copy to clipboard operation
SingleFile copied to clipboard

Support edition of iframe elements in the annotation editor

Open dnknn opened this issue 5 years ago • 4 comments

209_23053357

👆contenteditable="true" Edit mode, not work in iframe.
Currently it can be implemented manually. e.g. contenteditable="true" into iframe body html

dnknn avatar Sep 23 '20 01:09 dnknn

Unfortunately, the code from "Typio Form Recovery" would not work in the annotation editor of SingleFile. Actually, for security reasons, I've made sure that the page displayed in the annotation editor is totally sandboxed. I want to avoid that an eventual "malicious" script would access to the API used by extensions (which are quite powerful). The problem is that the sandbox is also quite effective and also blocks access to frame contents from the SingleFile code itself...

gildas-lormeau avatar Sep 23 '20 15:09 gildas-lormeau

Okay, it's not a big problem. After all, iframes are very special, so don't worry about it.

dnknn avatar Sep 23 '20 15:09 dnknn

We can let the issue open though ;)

gildas-lormeau avatar Sep 23 '20 15:09 gildas-lormeau

Even if this issue technically complicated to fix, I prefer to keep it open as a reminder.

gildas-lormeau avatar Jun 09 '21 19:06 gildas-lormeau