SingleFile icon indicating copy to clipboard operation
SingleFile copied to clipboard

Improve handling of bookmarks in SingleFile

Open DinoFive opened this issue 1 year ago • 4 comments

Hi @gildas-lormeau, the fix is working for the scenario where I change the folder it is saved to from another folder to the target folder, but there are two situations that seem buggy to me:

  1. When I bookmark a page, it starts the save process. If I click Cancel in the bookmark popup the page is still downloaded.
  2. When I bookmark a page, it starts the save process. But then I change the Location in the bookmark popup to a different folder. The page is still downloaded even though the bookmark is in the wrong folder.

These scenarios are less problematic than the one you fixed, as I can manually delete the file myself.

Originally posted by @willlma in https://github.com/gildas-lormeau/SingleFile/issues/933#issuecomment-1122756432

DinoFive avatar Jun 09 '23 09:06 DinoFive

As a solution to what willlma described, can SingleFile create a bookmark of the saved webpage to a certain folder automatically when I click the extension Icon to save the webpage?

DinoFive avatar Jun 09 '23 09:06 DinoFive

@DinoFive Unfortunately, this is not technically possible because SingleFile is not able to know the path of the saved page on the disk.

gildas-lormeau avatar Jun 13 '23 14:06 gildas-lormeau

@DinoFive Unfortunately, this is not technically possible because SingleFile is not able to know the path of the saved page on the disk.

@gildas-lormeau SingleFile now can "link the new bookmark to the saved page". How is this possible?

DinoFive avatar Jun 14 '23 06:06 DinoFive

@DinoFive You're right, I forgot it was possible. You can include a folder name in the File name > template option.

gildas-lormeau avatar Jul 23 '23 19:07 gildas-lormeau