react-joyride icon indicating copy to clipboard operation
react-joyride copied to clipboard

Is there any way to tell the component where to create the tour elements instead of it automatically being created at the end of the body?

Open kintz09 opened this issue 5 years ago • 11 comments

Hello! I recently discovered this wonderful package and I've just finished implementing a few product tours in my React web application. However, I am now running into an issue with the component when our app is fullscreen and need help finding a solution.

Our React application is designed to be embedded into other webpages. We offer functionality to go into fullscreen mode within our application. When we do this, we don't bring the entire webpage into fullscreen. We take our app's parent container into fullscreen.

I've noticed that the react-joyride elements always get created inside Body before the closing tag. Therefore, if we are in the middle of our tour and the user jumps into fullscreen mode, the joyride elements don't come with us. And similarly, if we are in fullscreen when we initialize the tour, the joyride elements aren't visible because they are not a child of the element we brought into fullscreen.

I looked through the documentation and issues for react-joyride and react-floater to see if this has been addressed already, but I didn't find anything.

Is there an existing way to tell the component where it should create itself? If not, could we add a new prop to react-joyride that accepts a reference or similar of the parent element where we want the react-joyride elements to be created?

Any help or suggestions would be greatly appreciated. Please let me know if there any other information I can provide to help.

kintz09 avatar Nov 14 '19 00:11 kintz09

Hey, There's no way to do that right now. I'll need to upgrade react-floater package to support it. I'll work on it when I have some spare time

gilbarbara avatar Dec 15 '19 13:12 gilbarbara

Stale issue message

github-actions[bot] avatar Mar 06 '20 00:03 github-actions[bot]

Hello! Great library, thank you! I also running into an issue when red marker try to follow clipped element: Screen Recording 2020-04-10 at 12 59 PM

And this feature may solve my issue too Or maybe there exists another way to clip that marker

a-pachkov avatar Apr 13 '20 18:04 a-pachkov

@a-pachkov You can change the z-index to prevent that behavior

gilbarbara avatar Apr 16 '20 22:04 gilbarbara

@gilbarbara Thank you for the replay! Sure I can manage this issue with right z-index on header and horizontal menus But in this case I'll need to set different z-index for each marker depending on place and clip elements around this place For example I'll need this marker in header or in pop-up window So it can add a lot of mess in the code and the pain of maintaining it But anyway thank you!

a-pachkov avatar Apr 17 '20 08:04 a-pachkov

@a-pachkov

So it can add a lot of mess in the code and the pain of maintaining it

Now imagine that in a library used by thousands! 😀

gilbarbara avatar Apr 20 '20 14:04 gilbarbara

When to upgrade embedded react-floater to support this?

Astra-RX avatar Sep 20 '22 07:09 Astra-RX

Same issue here.. Would be nice to have a solution for this.

sebass avatar Dec 19 '22 09:12 sebass