react-joyride icon indicating copy to clipboard operation
react-joyride copied to clipboard

Fix overlay spotlight

Open maoryadin opened this issue 9 months ago • 4 comments

Update hideSpotlight function and componentWillUnmount method in src/components/Overlay.tsx.

  • Add continuous to the destructured props in the hideSpotlight function.
  • Update the hiddenLifecycles array to include LIFECYCLE.BEACON, LIFECYCLE.COMPLETE, and LIFECYCLE.ERROR.
  • Update the shouldHide variable to account for the continuous property.
  • Update the hideSpotlight function to return shouldHide.
  • Add state reset for mouseOverSpotlight to componentWillUnmount method.

maoryadin avatar Mar 25 '25 16:03 maoryadin

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders
Open Preview

codesandbox[bot] avatar Mar 25 '25 16:03 codesandbox[bot]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

codesandbox-ci[bot] avatar Mar 25 '25 16:03 codesandbox-ci[bot]

Hey @maoryadin

Did you try the pre-release version?

npm i react-joyride@next

Do you still have the problem with it?

gilbarbara avatar Mar 25 '25 19:03 gilbarbara

Hey @maoryadin

Did you try the pre-release version?

npm i react-joyride@next

Do you still have the problem with it?

Yes, the pre-release version does not fix the issues I resolved in my PR. I could use a forked version of the release, but I thought it would be nice to make it available for everyone.

maoryadin avatar Mar 25 '25 19:03 maoryadin