react-joyride icon indicating copy to clipboard operation
react-joyride copied to clipboard

Fix: Resolve spotlight flickering issue on elements with spotlightClicks enabled

Open maoryadin opened this issue 9 months ago • 3 comments

Description: This PR refactors the hideSpotlight method to resolve a flickering issue when interacting with elements with spotlightClicks enabled.

Key Changes: • Optimized hideSpotlight logic: Simplified and memoized the hidden lifecycle conditions by moving hiddenLifecycles to a constant outside the method. • Bug Fix: Previously, the spotlight would briefly flicker when clicking elements with spotlightClicks enabled due to unnecessary re-evaluations of the overlay condition. The updated logic ensures consistent behavior by streamlining the condition check.

maoryadin avatar Mar 24 '25 10:03 maoryadin

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders
Open Preview

codesandbox[bot] avatar Mar 24 '25 10:03 codesandbox[bot]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

codesandbox-ci[bot] avatar Mar 24 '25 10:03 codesandbox-ci[bot]

Hey @maoryadin

Did you try the pre-release version?

npm i react-joyride@next

Do you still have the problem with it?

gilbarbara avatar Mar 25 '25 19:03 gilbarbara