react-joyride icon indicating copy to clipboard operation
react-joyride copied to clipboard

Peer deps on next/react 19

Open thenick775 opened this issue 9 months ago โ€ข 4 comments

Hey hey man, just wanting to see if on the next branch we can bump @gilbarbara/[email protected] upwards to avoid peer dep warnings with react 19?

Reproduction:

  • in a project that uses react-joyride@next
  • rm -rf ./node_modules
  • npm i

Produces:

npm warn ERESOLVE overriding peer dependency
npm warn While resolving: @gilbarbara/[email protected]
npm warn Found: [email protected]
npm warn node_modules/react
npm warn   react@"^19.0.0" from the root project
npm warn   33 more (@emotion/react, @emotion/styled, ...)
npm warn
npm warn Could not resolve dependency:
npm warn peer react@"16.8 - 18" from @gilbarbara/[email protected]
npm warn node_modules/react-joyride/node_modules/@gilbarbara/hooks
npm warn   @gilbarbara/hooks@"^0.8.2" from [email protected]
npm warn   node_modules/react-joyride
npm warn
npm warn Conflicting peer dependency: [email protected]
npm warn node_modules/react
npm warn   peer react@"16.8 - 18" from @gilbarbara/[email protected]
npm warn   node_modules/react-joyride/node_modules/@gilbarbara/hooks
npm warn     @gilbarbara/hooks@"^0.8.2" from [email protected]
npm warn     node_modules/react-joyride

Version used:

"react-joyride": "^3.0.0-7",

thenick775 avatar Mar 21 '25 02:03 thenick775

@gilbarbara Any idea when you release the next branch with this issue resolved? This is one of our packages that holds back upgrading to React 19.

DHFW avatar Apr 18 '25 07:04 DHFW

We can override these ourselves ๐Ÿ˜Ž

"overrides": {
  "@gilbarbara/hooks": "^0.8.2"
}

Just wanted to call it out!

thenick775 avatar Apr 21 '25 00:04 thenick775

Same for us, we are up to go for React 19, except React Joyride that prevent us to do it ๐Ÿ™„

Jean-Dum avatar Apr 21 '25 09:04 Jean-Dum

Same for us, we are up to go for React 19, except React Joyride that prevent us to do it ๐Ÿ™„

Same for us as well. We are using the next branch and itโ€™s working fine, but weโ€™re waiting for an official release on npm with a proper version.

Kavan72 avatar Apr 21 '25 14:04 Kavan72