Gil Amran comments

Results 59 comments of


                                            Gil Amran

Does not shutdown completely when run from the CLI

I did a test (using your example code) and the Ctrl-C did terminate the process (Using SIGINT). I'm using Mac. What's your OS?

Does not shutdown completely when run from the CLI

I'm using the exact same versions, and Ctrl-C just stops the process... I don't see what you're describing... What am I missing?

Does not shutdown completely when run from the CLI

how can we do a private chat?

Does not shutdown completely when run from the CLI

I see that you're online... lets do zoom now

Does not shutdown completely when run from the CLI

https://zoom.us/j/93636684173?pwd=Qlh2RGExTFVoK3JsY25ZQm1GaGg3QT09

Does not shutdown completely when run from the CLI

I've pushed a branch `test-kill` please try it.

Child processes that don't die after SIGTERM are orphaned

What would you suggest I should change? Please also note that we had an issue with killing processes in the past, take a look at #71

Child processes that don't die after SIGTERM are orphaned

Sounds good, How can I reproduce the "hanging" situation?

Child processes that don't die after SIGTERM are orphaned

How would you suggest fixing this?

Child processes that don't die after SIGTERM are orphaned

@david-alexander regarding the issue you found, it sounds like something that needs to be fixed. Please do a PR and we'll talk about it there. (Thanks!) Regarding `async/await` we've started...