priority-navigation
priority-navigation copied to clipboard
Minor issues
Great script, i think it is the most complete i found, I already implemented it. Some minor issues:
I found class setting restrictive, it could allow for multiple class entry favoring css code reuse when you do bring your own, without going:
.main-nav,
.main-nav-dropdown{}
For instance:
var nav = priorityNav.init({
mainNavWrapper: "main-nav-wrapper",
mainNav: "main-nav",
navDropdownClassName: '.main-nav.dropdown',
navDropdownToggleClassName: 'main-nav-toggle',
navDropdownLabel: '<i class="fa fa-caret-down"></i> más',
});
Can none of the parent containters of 'mainNav' can be floated nor absolute, but only fixed? I had to change the layout to comply to that requirement. Why is it so?
It would be nice if you specify in REAME that options are default values, and some are required. Somewhat obvious but at first when I read var nav = priorityNav.init(); was all there was needed to initialize, It didn't work.