gijsbers

Results 379 comments of gijsbers

The messages point out that it is not about math but about types. Just stop using unsigned for width and height if you frequently need to combine them with signed...

It caused a number of bugs, some of which are still not solved... There was enough work to be done already...

Probably related: icewmbg only draws the top part of of the background for me. Valgrind reports: ``` ==26824== Syscall param writev(vector[...]) points to uninitialised byte(s) ==26824== at 0x74F9430: __writev_nocancel (in...

I can reproduce the keepass crash easily: ``` ==25241== Invalid read of size 8 ==25241== at 0x49000F: YXImage::composite(Graphics&, int, int, unsigned int, unsigned int, int, int) (yximage.cc:955) ==25241== by 0x476D01:...

@bbidulock yeah some jpeg which is 2.3 times too big.

YXImage::composite incorrectly assumes that a Graphics always has a non-null color(), which leads to the crash...

Yeah Dark-Ice is really useful for testing. The icon upscaling is still no good as Dark-Ice shows vertical stripes for some icons for me now, but at least it doesn't...

The extra line and corruption is still there in module yximage. More yximage corruption issues show up when the taskbar has lots of task buttons.

Yeah, write some in the documentation about this and include that in the git commits.

Can't reproduce this anywhere.