Luigi Teschio

Results 86 comments of Luigi Teschio

> I am wondering what happens when the user has automatic updates enabled? Or when the host manages the upgrade e.g. WooExpress. Good point, we have the same issue.

> So if the users site automatically upgrades WooCommerce, and then they login. Do the migrations run? The migration will run when they land on `/wp-admin` dashboard. > If not,...

I reopen this issue since that woocommerce/woocommerce-blocks#10205 is a workaround and not a future-proof solution.

Thanks for the ping, @sunyatasattva! It makes sense to reduce the priority to normal! > but we should look into closing this issue altogether and perhaps removing the workaround introduced...

> Just to clarify, the agreement is to remove the migration altogether or to remove only the work-around from https://github.com/woocommerce/woocommerce-blocks/pull/10205? The agreement is to remove only the workaround given that...

@Aljullu, upon further consideration, it might be beneficial to streamline our approach by eliminating the WC Blocks' Migration class and leveraging the WC_Install class instead. ([source code](https://github.com/woocommerce/woocommerce/blob/9a1d11c1ba8a4c3e4eb5ce22b1a6866894772238/plugins/woocommerce/includes/class-wc-install.php)) Currently, WC Blocks...

Thanks for your great review! Given that the full compatibility will require many changes (and rely on experimental APIs), I'm proceeding with small PRs. The goal of this PR is...

> I'm going ahead and marking this PR as blocked: the issues identified here are too critical for us to merge it without solving them, especially being unable to scroll...

> @gigitux Thanks for working on this, I'm seeing a few issues: > > 1. In the first template sidebar preview there are some errors. > 2. When I change...

> Could we investigate if this issue is indeed a consequence of a regression on GB and not from this PR? I checked the WooCommerce trunk branch, and I'm able...