OctoLight icon indicating copy to clipboard operation
OctoLight copied to clipboard
verified publisher icon gigibu5

Added support for a physical button and led strip

Open emouty opened this issue 4 years ago • 4 comments

Hello,

I have added :

  • support for a physical button to control the light.
  • support for a led strip using the rpi_ws281x library

I also did some refactoring in the __init__.py, so there might be some conflicts with other ongoing pull request.

Note: I haven't found why (might just be my Pi) but the board was stuck in BCM mode so i switch the GPIO mode to BCM

emouty avatar Mar 21 '21 12:03 emouty

Thank you for your pull request. Saddly, I do not have any RGB strips at hand to test it. If you could resolve the confilcts (some stuff was merged) and send me a video of it working as well as some screenshots of the setting panel and user interface, I would be happy to merge it.

gigibu5 avatar Mar 21 '21 19:03 gigibu5

Also, please change the indentation from 4 spaces to a single tab.

gigibu5 avatar Mar 21 '21 19:03 gigibu5

I did the rebase on your repository, I also added the change of the light icon in the UI when you press the physical button to turn on and off the light. I will send you the video soon, I just need to finish some wiring on the printer before

emouty avatar Apr 04 '21 16:04 emouty

i've tested your PR and except the one bug it seems to work properly

(normal light pin and button, i have not tested the LED strip feature)

eloo avatar Oct 31 '21 17:10 eloo